Hi Loic,
On 10/21/20 9:51 AM, Loic Poulain wrote:
On Wed, 21 Oct 2020 at 18:25, Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
On Wed, Oct 21, 2020 at 05:43:14PM +0200, Loic Poulain wrote:
On Wed, 21 Oct 2020 at 17:27, Manivannan Sadhasivam <
manivannan.sadhasivam@xxxxxxxxxx> wrote:
On Fri, Oct 16, 2020 at 09:04:14PM -0700, Hemant Kumar wrote:
Introduce mhi_get_free_desc_count() API to return number
Would it not be a good idea to have naming aligned with other methods?
Like mhi_queue_num_free() or mhi_queue_no_free_elem...
'queue_num_free' doesn't sound like getting the number of available
descriptors...
Right, TBH, just wanted the function to start with mhi_queue since
it's about getting info about remaining size of the DL or UL 'virtual
queue'. But AFAIU, this is the number of available ring elements that
is returned here, not the number of transfer descriptors (that can be
composed of one or more ring elements), so maybe
mhi_queue_num_free_elements or something similar, I don't want to be
mhi_get_free_desc_count is the number of TREs available which queue APIs
can use to queue an transfer ring element. My only concern is if we get
confused with the name mhi_queue_ part of as number of TREs queued ?
Transfer ring element is indeed a transfer descriptor.
picky here.
Regards,
Loic
Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
