On 03/10/2020 00:14, Evan Green wrote:
You don't want either/or. You want both. At the time Srinivas didn't see the point of having the SoC-specific compatible string here, but now that we have a reason for it maybe he'll be convinced? IMO you essentially want: items: - enum: - qcom,apq8064-qfprom - qcom,apq8084-qfprom - qcom,msm8974-qfprom - qcom,msm8916-qfprom - qcom,msm8996-qfprom - qcom,msm8998-qfprom - qcom,qcs404-qfprom - qcom,sc7180-qfprom - qcom,sdm845-qfprom - const: qcom,qfprom For some context: <https://lore.kernel.org/r/CAD=FV=WjvAWVmq3fTh=_f2p1Dv+sXg1RV-CqZr8KRgHe8_wT0w@xxxxxxxxxxxxxx/>That makes sense, thanks Doug. Srini, do you want me to go fix up all the various device trees to add the soc-compatible string, or just sc7180? (Also, don't forget about my other question about whether you still want the keepout stuff in the core at the cost of added complexity).
Lets keep the existing users as it for now! and we can still list compatibles in the bindings so that any new users (including sc7180) can start using them when needed!
thanks, srini
-Evan
