On 9/23/2020 9:17 AM, Bjorn Andersson wrote:
On Wed 23 Sep 08:40 CDT 2020, Loic Poulain wrote:
This is a generic MHI-over-PCI controller driver for MHI only devices
such as QCOM modems. For now it supports registering of Qualcomm SDX55
based PCIe modules. The MHI channels have been extracted from mhi
downstream driver.
This driver is easily extendable to support other MHI PCI devices like
different modem hw or OEM superset.
Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
---
[..]
diff --git a/drivers/bus/mhi/controllers/mhi_pci_common.c b/drivers/bus/mhi/controllers/mhi_pci_common.c
new file mode 100644
index 0000000..705b283
--- /dev/null
+++ b/drivers/bus/mhi/controllers/mhi_pci_common.c
ath11k is also "PCI" and "MHI" but this isn't "common" code for it, so
perhaps "mhi_pci_generic.c" or "mhi_pci_modem.c"?
It occurs to me from seeing Bjorn's comment, GregKH had a pretty hard
objection to creating a directory for the mhi_uci driver (more or less
its pointless to have a directory for a single file, wait until there
are a mess of files that need to be managed), and this patch is doing
the same thing. I would suggest dropping the "controllers" directory,
and just putting this in the root mhi directory.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
