Quoting Jonathan Marek (2020-09-03 16:29:43)
> On 9/2/20 7:02 PM, Stephen Boyd wrote:
>
> ...
>
> > +static const struct qmp_phy_cfg sc7180_dpphy_cfg = {
> > + .type = PHY_TYPE_DP,
> > + .nlanes = 1,
> > +
> > + .serdes_tbl = qmp_v3_dp_serdes_tbl,
> > + .serdes_tbl_num = ARRAY_SIZE(qmp_v3_dp_serdes_tbl),
> > + .tx_tbl = qmp_v3_dp_tx_tbl,
> > + .tx_tbl_num = ARRAY_SIZE(qmp_v3_dp_tx_tbl),
> > +
> > + .serdes_tbl_rbr = qmp_v3_dp_serdes_tbl_rbr,
> > + .serdes_tbl_rbr_num = ARRAY_SIZE(qmp_v3_dp_serdes_tbl_rbr),
> > + .serdes_tbl_hbr = qmp_v3_dp_serdes_tbl_hbr,
> > + .serdes_tbl_hbr_num = ARRAY_SIZE(qmp_v3_dp_serdes_tbl_hbr),
> > + .serdes_tbl_hbr2 = qmp_v3_dp_serdes_tbl_hbr2,
> > + .serdes_tbl_hbr2_num = ARRAY_SIZE(qmp_v3_dp_serdes_tbl_hbr2),
> > + .serdes_tbl_hbr3 = qmp_v3_dp_serdes_tbl_hbr3,
> > + .serdes_tbl_hbr3_num = ARRAY_SIZE(qmp_v3_dp_serdes_tbl_hbr3),
> > +
> > + .clk_list = qmp_v3_phy_clk_l,
> > + .num_clks = ARRAY_SIZE(qmp_v3_phy_clk_l),
> > + .reset_list = sc7180_usb3phy_reset_l,
> > + .num_resets = ARRAY_SIZE(sc7180_usb3phy_reset_l),
> > + .vreg_list = qmp_phy_vreg_l,
> > + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
>
> You need a ".regs = qmp_v3_usb3phy_regs_layout," here, otherwise phy
> init functions like qcom_qmp_phy_serdes_init() can crash on a NULL
> reference.
>
Ah got it. I didn't see a problem because the USB phy probes first for
me.
