On Thu, Aug 20, 2020 at 09:53:40PM -0600, Rob Herring wrote: > This is a series of clean-ups for the Designware PCI driver. The series > initially reworks the config space accessors to use the existing pci_ops > struct. Then there's removal of various private data that's also present > in the pci_host_bridge struct. There's also some duplicated common (PCI > and DWC) register defines which I converted to use the common defines. > Finally, the initialization for speed/gen, number of lanes, and N_FTS > are all moved to the common DWC code. > > This is compile tested only as I don't have any DWC based h/w, so any > testing would be helpful. A branch is here[1]. Applied the series to pci/dwc, thanks. Lorenzo > Rob > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-dw-cleanups > > Rob Herring (40): > PCI: Allow root and child buses to have different pci_ops > PCI: dwc: Use DBI accessors instead of own config accessors > PCI: dwc: Allow overriding bridge pci_ops > PCI: dwc: Add a default pci_ops.map_bus for root port > PCI: dwc: al: Use pci_ops for child config space accessors > PCI: dwc: keystone: Use pci_ops for config space accessors > PCI: dwc: tegra: Use pci_ops for root config space accessors > PCI: dwc: meson: Use pci_ops for root config space accessors > PCI: dwc: kirin: Use pci_ops for root config space accessors > PCI: dwc: exynos: Use pci_ops for root config space accessors > PCI: dwc: histb: Use pci_ops for root config space accessors > PCI: dwc: Remove dwc specific config accessor ops > PCI: dwc: Use generic config accessors > PCI: Also call .add_bus() callback for root bus > PCI: dwc: keystone: Convert .scan_bus() callback to use add_bus > PCI: dwc: Convert to use pci_host_probe() > PCI: dwc: Remove root_bus pointer > PCI: dwc: Remove storing of PCI resources > PCI: dwc: Simplify config space handling > PCI: dwc/keystone: Drop duplicated 'num-viewport' > PCI: dwc: Check CONFIG_PCI_MSI inside dw_pcie_msi_init() > PCI: dwc/imx6: Remove duplicate define PCIE_LINK_WIDTH_SPEED_CONTROL > PCI: dwc: Add a 'num_lanes' field to struct dw_pcie > PCI: dwc: Ensure FAST_LINK_MODE is cleared > PCI: dwc/meson: Drop the duplicate number of lanes setup > PCI: dwc/meson: Drop unnecessary RC config space initialization > PCI: dwc/meson: Rework PCI config and DW port logic register accesses > PCI: dwc/imx6: Use common PCI register definitions > PCI: dwc/qcom: Use common PCI register definitions > PCI: dwc: Remove hardcoded PCI_CAP_ID_EXP offset > PCI: dwc/tegra: Use common Designware port logic register definitions > PCI: dwc: Remove read_dbi2 code > PCI: dwc: Make ATU accessors private > PCI: dwc: Centralize link gen setting > PCI: dwc: Set PORT_LINK_DLL_LINK_EN in common setup code > PCI: dwc/intel-gw: Drop unnecessary checking of DT 'device_type' > property > PCI: dwc/intel-gw: Move getting PCI_CAP_ID_EXP offset to > intel_pcie_link_setup() > PCI: dwc/intel-gw: Drop unused max_width > PCI: dwc: Move N_FTS setup to common setup > PCI: dwc: Use DBI accessors > > drivers/pci/controller/dwc/pci-dra7xx.c | 29 +- > drivers/pci/controller/dwc/pci-exynos.c | 45 +-- > drivers/pci/controller/dwc/pci-imx6.c | 52 +-- > drivers/pci/controller/dwc/pci-keystone.c | 126 ++----- > drivers/pci/controller/dwc/pci-meson.c | 156 ++------- > drivers/pci/controller/dwc/pcie-al.c | 70 +--- > drivers/pci/controller/dwc/pcie-artpec6.c | 48 +-- > .../pci/controller/dwc/pcie-designware-ep.c | 11 +- > .../pci/controller/dwc/pcie-designware-host.c | 319 ++++++------------ > .../pci/controller/dwc/pcie-designware-plat.c | 4 +- > drivers/pci/controller/dwc/pcie-designware.c | 104 +++--- > drivers/pci/controller/dwc/pcie-designware.h | 54 +-- > drivers/pci/controller/dwc/pcie-histb.c | 45 +-- > drivers/pci/controller/dwc/pcie-intel-gw.c | 65 +--- > drivers/pci/controller/dwc/pcie-kirin.c | 43 +-- > drivers/pci/controller/dwc/pcie-qcom.c | 33 +- > drivers/pci/controller/dwc/pcie-spear13xx.c | 39 +-- > drivers/pci/controller/dwc/pcie-tegra194.c | 120 ++----- > drivers/pci/controller/dwc/pcie-uniphier.c | 3 +- > drivers/pci/probe.c | 14 +- > include/linux/pci.h | 1 + > 21 files changed, 443 insertions(+), 938 deletions(-) > > -- > 2.25.1