RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Bao D. Nguyen" <nguyenb@xxxxxxxxxxxxxx>, "cang@xxxxxxxxxxxxxx" <cang@xxxxxxxxxxxxxx>, "asutoshd@xxxxxxxxxxxxxx" <asutoshd@xxxxxxxxxxxxxx>, "martin.petersen@xxxxxxxxxx" <martin.petersen@xxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer
From: Avri Altman <Avri.Altman@xxxxxxx>
Date: Sat, 29 Aug 2020 07:32:05 +0000
Cc: "linux-arm-msm@xxxxxxxxxxxxxxx" <linux-arm-msm@xxxxxxxxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, Stanley Chu <stanley.chu@xxxxxxxxxxxx>, Nitin Rawat <nitirawa@xxxxxxxxxxxxxx>, Bean Huo <beanhuo@xxxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <b141cfcd7998b8933635828b56fbb64f8ad4d175.1598661071.git.nguyenb@codeaurora.org>
References: <b141cfcd7998b8933635828b56fbb64f8ad4d175.1598661071.git.nguyenb@codeaurora.org>
Wdcipoutbound: EOP-TRUE

 
> 
> The zero value Auto-Hibernate Timer is a valid setting, and it
> indicates the Auto-Hibernate feature being disabled. Correctly
Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate name.
Maybe ufshcd_auto_hibern8_set instead?

Also, did you verified that no other platform relies on its non-zero value?

Thanks,
Avri

Follow-Ups:
- Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer
  - From: nguyenb

References:
- [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer
  - From: Bao D. Nguyen

Prev by Date: [RFC v5 2/6] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic
Next by Date: Re: [PATCH 09/18] iommu/mediatek-v1: Add IOMMU_DOMAIN_DMA support
Previous by thread: Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer
Next by thread: Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]