Hi,
On Fri, Aug 28, 2020 at 2:15 AM Naresh Kamboju
<naresh.kamboju@xxxxxxxxxx> wrote:
>
> On Fri, 28 Aug 2020 at 01:57, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
> >
> > On Thu, 27 Aug 2020 at 21:03, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> > >
> > > The commit d05a7238fe1c ("mmc: sdhci-msm: Unconditionally call
> > > dev_pm_opp_of_remove_table()") works fine in the case where there is
> > > no OPP table. However, if there is an OPP table then
> > > dev_pm_opp_of_add_table() will return 0. Since 0 != -ENODEV then the
> > > "if (ret != -ENODEV)" will evaluate to true and we'll fall into the
> > > error case. Oops.
> > >
> > > Let's fix this.
> > >
> > > Fixes: d05a7238fe1c ("mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()")
> > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> >
> > Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> >
> > I will test this patch and report again on this email thread.
>
> Sorry this patch did not solve the reported problem.
To be fair, I wasn't trying to. ;-) That's why I didn't add
Reported-by to my original patch. I was trying to solve problems I
was seeing myself and my patch did solve the problems I was seeing. I
only CCed you because I saw that you were having problems with the
same patch...
> However, I would be testing the V2 set from Viresh Kumar.
I've confirmed that the current mmc/next (with Viresh's new patch) no
longer breaks me. :-)
$ git show --format=fuller linux_mmc/next | head -8
commit 174e889d08aa54219b841464458f81d13fafec93
Merge: c282fdb49b18 8048822bac01
Author: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
AuthorDate: Fri Aug 28 14:26:25 2020 +0200
Commit: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
CommitDate: Fri Aug 28 14:26:25 2020 +0200
Merge branch 'fixes' into next
-Doug
