On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > +static int sc7180_parse_of(struct snd_soc_card *card) > > +{ > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > it will be nice to common this up, if possible! > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() a while ago already, but didn't find the time to finish it up. I have now sent it, this should make it possible to use the common qcom_snd_parse_of() function in this driver as well. See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@xxxxxxxxxxx/ Stephan