On Sun, 19 Jul 2020, Sam Ravnborg wrote: > Hi all. > > Follow-up on v4 - with only a few changes listed below and > in the individual patches. > Thanks for all the reviews and the feedback on the patches! > > I am planning a follow-up on this patchset to update the > backlight drivers all over to use backlight_get_brightness() > and backlight_is_blank() as appropriate. [...] > Sam Ravnborg (19): > backlight: refactor fb_notifier_callback() > backlight: add backlight_is_blank() > backlight: improve backlight_ops documentation > backlight: improve backlight_properties documentation > backlight: improve backlight_device documentation > backlight: document inline functions in backlight.h > backlight: document enums in backlight.h > backlight: remove the unused backlight_bl driver > backlight: drop extern from prototypes > backlight: add overview and update existing doc > backlight: wire up kernel-doc documentation > backlight: introduce backlight_get_brightness() > backlight: as3711_bl: simplify update_status > backlight: cr_bllcd: introduce gpio-backlight semantics > backlight: gpio_backlight: simplify update_status() > backlight: jornada720_bl: introduce backlight_is_blank() > backlight: use backlight_get_brightness() > backlight: drop backlight_put() > backlight: make of_find_backlight static All applied, but to be honest, that was quite painful. A few notes for subsequent patches. - Enable spell-checkers in your editors - I fixed the issues up for you here - there were quite a few! - Run ./checkpatch.pl before submitting - here's what I find useful * .git/hooks/post-commit: https://pastebin.ubuntu.com/p/WpPFd6M2rB/ - Please keep the in-patch changelog below the '---' line, so that it does not end up in the final commit log - Cc: lines *above* the *-bys please - Cc: lines dropped for any *-bys provided - Lines wrapped ~72 chars (not 50) - One whole empty line spacing between paragraphs - Ensure you use the formatting expected of the subsystem - in the case of Backlight it's: <subsystem>: <file>: Subject beginning with an upper-case char A `git log --oneline -- subsystem` would give you a good idea of what's expected. -- lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
