On Fri, Jul 17, 2020 at 10:39 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> wrote: > > > > On Fri, Jul 17, 2020 at 08:04:18PM +0530, Akhil P Oommen wrote: > > > On targets where GMU is available, GMU takes over the ownership of GX GDSC > > > during its initialization. So, move the refcount-get on GX PD before we > > > initialize the GMU. This ensures that nobody can collapse the GX GDSC > > > once GMU owns the GX GDSC. This patch fixes some GMU OOB errors seen > > > during GPU wake up during a system resume. > > > > > Signed-off-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx> > > > Reported-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > > Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > > > The Signed-off-by needs to be at the end but I think Rob can do that for you. > > It does? I've always been told that this is supposed to be roughly a > log of what happens. In that sense you added your SoB before the > review/test happened so it should come before. I know some > maintainers seem to do things differently but that seems to be the > most common. In that sense, I think the order that Akhil has is > correct. ...but, obviously, it's up to the maintainer. ;-) yeah, I chronological order was my understanding too.. but presumably the Reported-by happened before the Signed-of-by (which is how I reordered things when applying the patch) BR, -R
