Rajendra, On Fri, Jul 10, 2020 at 5:41 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Jul 09, 2020 at 03:07:00PM +0530, Rajendra Nayak wrote: > > When using the geni-serial as console, its important to be > > able to hit the lowest possible power state in suspend, > > even with no_console_suspend. > > The only thing that prevents it today on platforms like the sc7180 > > is the interconnect BW votes, which we certainly don't need when > > the system is in suspend. So in the suspend handler mark them as > > ACTIVE_ONLY (0x3) and on resume switch them back to the ALWAYS tag (0x7) > > > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> > > --- > > Note: Patch applies on qcom for-next, which has the ICC support patches. > > The tag macros are currently not exported and hence the hardcoded values. > > Perhaps if and when https://patchwork.kernel.org/patch/11619705/ lands I > > can refresh this patch to use the macros. > > Feel free to take this patch through that tree. > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Could you post a v2? Bjorn landed some of my geni serial patches to make console / kgdb work better, but then I realized that your patch no longer applies cleanly. It's trivial to resolve, so hopefully a v2 should be quick and then Bjorn can land? Thanks! -Doug
