Quoting Marc Zyngier (2020-06-27 02:37:47) > On Sat, 27 Jun 2020 02:34:25 +0100, > John Stultz <john.stultz@xxxxxxxxxx> wrote: > > > > On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > > > > > > Is there any reason to use IRQCHIP_DECLARE if this can work as a > > > platform device driver? > > > > > > > Hey! Thanks so much for the review! > > > > Mostly it was done this way to minimize the change in the non-module > > case. But if you'd rather avoid the #ifdefery I'll respin it without. > > That would certainly be my own preference. In general, IRQCHIP_DECLARE > and platform drivers should be mutually exclusive in the same driver: > if you can delay the probing and have it as a proper platform device, > then this should be the one true way. > Does it work? I haven't looked in detail but I worry that the child irqdomain (i.e. pinctrl-msm) would need to delay probing until this parent irqdomain is registered. Or has the hierarchical irqdomain code been updated to handle the parent child relationship and wait for things to probe or be loaded?
