On 06-07-20, 22:08, Bjorn Andersson wrote: > On Mon 29 Jun 21:54 PDT 2020, Vinod Koul wrote: > > > Hi Bjorn, > > > > On 29-06-20, 12:24, Bjorn Andersson wrote: > > > On Mon 29 Jun 07:54 PDT 2020, Vinod Koul wrote: > > > > > > > UFS QMP phy drivers are duplicate as we are supposed to use common QMP > > > > phy driver which is working fine on various platforms. So remove the > > > > unused driver > > > > > > > > > > This describes the current state, but the UFS QMP driver had a purpose > > > not that long ago and I would like the commit message to describe what > > > changed and why it's now fine to remove the driver. > > > > Would below look better, also feel free to suggest as you have the > > more history on this :) > > > > "UFS QMP driver is dedicated driver for QMP phy for UFS variant. We > > also have a common QMP phy driver which works not only for UFS but > > USB and PCIe as well, so retire this driver in favour of the common > > driver" > > > > How about: > > "The UFS specific QMP PHY driver started off supporting the 14nm and > 20nm hardware. With the 20nm support marked broken for a long time and > the 14nm support added to the common QMP PHY, this driver has not been > used in a while. So delete it." I have applied it with above log, thanks -- ~Vinod
