From: Tom Rix <trix@xxxxxxxxxx> In a randconfig, qcom-geni-se.c breaks with drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_remove_earlycon_icc_vote’: drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function ‘of_get_next_parent’; did you mean ‘of_get_parent’? [-Werror=implicit-function-declaration] parent = of_get_next_parent(wrapper->dev->of_node); ^~~~~~~~~~~~~~~~~~ of_get_parent qcom-geni-sec.c correctly includes the linux/of.h header. But the header depends on CONFIG_OF being set. So add depends to QCOM_GENI_SE Signed-off-by: Tom Rix <trix@xxxxxxxxxx> --- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 899f8c066797..f699cfa33d7d 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -29,6 +29,7 @@ config QCOM_COMMAND_DB config QCOM_GENI_SE tristate "QCOM GENI Serial Engine Driver" depends on ARCH_QCOM || COMPILE_TEST + depends on OF help This driver is used to manage Generic Interface (GENI) firmware based Qualcomm Technologies, Inc. Universal Peripheral (QUP) Wrapper. This -- 2.18.1