On Thu, Jul 2, 2020 at 3:31 PM Amit Kucheria <amit.kucheria@xxxxxxxxxx> wrote: > > On Thu, Jul 2, 2020 at 3:04 PM Loic Poulain <loic.poulain@xxxxxxxxxx> wrote: > > > > + > > thermal-zones { > > cpu0-thermal { > > polling-delay-passive = <250>; > > @@ -2180,18 +2429,33 @@ > > thermal-sensors = <&tsens0 3>; > > > > trips { > > - cpu0_alert0: trip-point@0 { > > + cpu_alert0: cpu_alert0 { > > Please use the node name pattern we're using in some of the other dtsi > filenames for consistency. See sdm845.dtsi for an example. > > This also fixes dtsi warnings about address units, I suspect. So the > name change may be a separate patch just to fix the warnings, if you > want. Turns out I did fix these names and the change got merge in the 5.8 merge window. What version of the kernel are these patches against? > > temperature = <75000>; > > hysteresis = <2000>; > > + type = "active";