On 6/18/2020 11:33 AM, Rob Herring wrote: > On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng <wcheng@xxxxxxxxxxxxxx> wrote: > > You are duplicating everything in usb-connector.yaml. You should have > a $ref to it. > Hi Rob, Sure, I will add a reference to that doc. > > This is wrong. The connector binding says port 0 is the connection the > USB HS controller. > > What's a type C mux node? Is there a binding for that? There's an > ongoing discussion with the CrOS folks on how to describe Alt mode > mux/switches. I reviewed the connector binding previously, and couldn't seem to come up with a model which fit a design where the type C controller (ie the entity which does the CC orientation and role detection) does not have the SS lane mux included. The SS lane mux is the HW which handles the selection of the SS lanes to utilize based on cable orientation. I looked at the FUSB302 TCPM driver, which doesn't have an integrated SS lane mux, and relies on an external FUSB340 switch to handle the polarity, but seems that in the fusb302.c driver it doesn't implement the polarity handler. They might possibly have a HW output signal which controls the mux directly, but I'm not sure on that. Anyway, if someone wanted to take a SW approach and program an external mux, this model doesn't seem to allow that. This is somewhat unrelated to the DP AUX mode switching, as that probably will only come into the picture after the policy engine has detected there is a DP adapter connected, whereas this is applicable to non DP/alt mode situations. Thanks! >> + type: object >> + >> + properties: >> + remote-endpoint: >> + maxItems: 1 >> + description: Node reference to the type C mux >> + >> + endpoint@1: >> + description: Connection to role switch node > > Again, what's this? > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
