On Tue, Jun 9, 2020 at 4:04 PM Rob Clark <robdclark@xxxxxxxxxxxx> wrote: > On Tue, Jun 9, 2020 at 5:48 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Tue, May 5, 2020 at 10:27 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > > > > > > I ran into a randconfig link error with debugfs disabled: > > > > > > > > arm-linux-gnueabi-ld: > > > > drivers/gpu/drm/msm/msm_gpu.o: in function `should_dump': msm_gpu.c:(.text+0x1cc): undefined reference to `rd_full' > > > > > > > > Change the helper to only look at this variable if debugfs is present. > > > > > > > > Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers") > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > > > This fixes a compilation error for me on the APQ8060. > > > Tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > > Could someone be so kind and apply this fix to the MSM DRM tree? > > > > This should be fixed by 20aebe83698feb107d5a66b6cfd1d54459ccdfcf in > msm-next/drm-next, are you still seeing this issue? Oh nice this works too, I was just rebasing my trees and the patch was still there, of course I didn't see that anothe patch fixed the same issue already. Thanks Rob! Linus Walleij