On 09-06-20, 12:41, Jonathan McDowell wrote: > On Fri, Jun 05, 2020 at 07:00:04PM +0200, ansuelsmth@xxxxxxxxx wrote: > > > On Wed, Jun 03, 2020 at 03:22:34PM +0200, Ansuel Smith wrote: > > > > This has lost in the original push for the dwc3 qcom driver. > > > > This is needed for ipq806x SoC as without this the usb ports > > > > doesn't work at all. > > > > > > FWIW I tested this on my RB3011 so feel free to add: > > > > > > Tested-by: Jonathan McDowell <noodles@xxxxxxxx> > > > > > > One minor comment; would PHY_QCOM_USB_IPQ806X not be a better > > > choice than PHY_QCOM_IPQ806X_USB given the existing naming? > > > > > > > Thanks for the feedback. About naming I'm following the sata ipq806x > > naming. I really hope someone gets this and reviews it since usb is > > broken for a long time now. > > Doesn't seem to have made the 5.8 merge window; I note Vinod has done a > bunch of the recent commits to phy/qualcomm/ so adding him to the CC in > addition to Kishon. It is too late for 5.8 now, please rebase and resend it after rc1 is tagged Thanks -- ~Vinod