Hi Mark, Thanks for the review! On Tue, 2 Jun 2020 at 16:54, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Tue, Jun 02, 2020 at 03:39:20PM +0530, Sumit Semwal wrote: > > > + > > + if (time_remaining <= 0) { > > + rdev_err(rdev, "Enabled check failed.\n"); > > + return -ETIMEDOUT; > > s/failed/timed out/ Ack > > > + * @poll_enabled_time: Maximum time (in uS) to poll if the regulator is > > + * actually enabled, after enable() call > > + * > > This comment needs updating to reflect the new implementation. Yes, I will update. Best, Sumit.