Quoting Sivaprakash Murugesan (2020-05-24 03:04:42) > add dt-binding for ipq6018 apss clock controller Capitalize 'add' because it starts the sentence. > > Signed-off-by: Sivaprakash Murugesan <sivaprak@xxxxxxxxxxxxxx> > --- > include/dt-bindings/clock/qcom,apss-ipq.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h > > diff --git a/include/dt-bindings/clock/qcom,apss-ipq.h b/include/dt-bindings/clock/qcom,apss-ipq.h > new file mode 100644 > index 0000000..77b6e05 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,apss-ipq.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ6018_H > +#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ6018_H > + > +#define APCS_ALIAS0_CLK_SRC 0 > +#define APCS_ALIAS0_CORE_CLK 1 Will this be extended in the future? I hope that this is the only two clks we expect to see in this file.