On Mon, May 18, 2020 at 12:16 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Linus. > > On Mon, May 18, 2020 at 10:10:12AM +0200, Linus Walleij wrote: > > On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > > > Look up backlight device using devm_of_find_backlight(). > > > This simplifies the code and prevents us from hardcoding > > > the node name in the driver. > > > > > > v2: > > > - Added Cc: Peter Ujfalusi > > > > > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > Cc: Russell King <linux@xxxxxxxxxxxxxxx> > > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > > Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > > > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > > > > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Thanks. I went ahead and applied this now, so we could kill > the last user of of_find_backlight_by_node(). > > I hope we can make of_find_backlight_by_node() static after the merge window > so no new users appears. For this driver (drivers/video/fbdev/amba-clcd.c) there are zero users after the merge window (all users moved over to DRM) so I plan to retire it completely. Yours, Linus Walleij