On Fri, May 22, 2020 at 6:37 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Fri, May 22, 2020 at 5:25 PM Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> wrote: > > > > The ADC architecture on PMIC7 is changed as compared to PMIC5. The > > major change from PMIC5 is that all SW communication to ADC goes through > > PMK8350, which communicates with other PMICs through PBS when the ADC > > on PMK8350 works in master mode. The SID register is used to identify the > > PMICs with which the PBS needs to communicate. Add support for the same. > > Below should be in a separate patch, but it's a bikeshedding. So, I > left it to maintainers to decide. > Fine with me Fine with me *after* addressing some issues below (besides ' < 0' part). > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko