Check if the device supports RDDM from the mhi_force_rddm_mode() API before allowing a client to force a device crash. This will ensure that a client who is unaware does not misuse the API and expect the device to go to ramdump collection mode after a crash is forced. Signed-off-by: Bhaumik Bhatt <bbhatt@xxxxxxxxxxxxxx> --- drivers/bus/mhi/core/pm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c index 1daed86..52c290c6 100644 --- a/drivers/bus/mhi/core/pm.c +++ b/drivers/bus/mhi/core/pm.c @@ -1114,6 +1114,10 @@ int mhi_force_rddm_mode(struct mhi_controller *mhi_cntrl) struct device *dev = &mhi_cntrl->mhi_dev->dev; int ret; + /* Check if device supports RDDM */ + if (!mhi_cntrl->rddm_image) + return -EINVAL; + /* Check if device is already in RDDM */ if (mhi_cntrl->ee == MHI_EE_RDDM) return 0; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
