On Mon, 18 May 2020 23:11:14 -0700 Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: > On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote: > > > Adds initial device tree for Xiaomi Redmi Note 8T, codename > > xiaomi-willow. It uses the sm6125 SoC. Currently only boots into > > initrd shell over UART. Requires appended DTB with qcom,board-id = > > <0x22 0x0> and qcom,msm-id = <0x18a 0x10000> to actually boot. > > > > If I read this correctly you need to supply board-id and msm-id in > order to be able to get this booting? > > Even though we don't like them, I would prefer if you just add them in > the dts file, in this patch. Yes, AFAICT the bootloader iterates over the appended DTBs and will only boot if it finds one with those matching properties. > > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb diff --git > > a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > > b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts new file mode > > 100644 index 0000000000000..444b32ccb9d48 --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > > @@ -0,0 +1,19 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > Please make this GPL/BSD dual license. > > Apart from these few remarks your patches looks good, looking forward > to see more of this platform! > > Regards, > Bjorn OK, thanks!
