Hi Luis,
On 2020-05-15 1:47 p.m., Luis Chamberlain wrote:
On Wed, May 13, 2020 at 12:23:59PM -0400, Mimi Zohar wrote:
Hi Scott,
On Thu, 2020-05-07 at 17:27 -0700, Scott Branden wrote:
Please consider this version series ready for upstream acceptance.
This patch series adds partial read support in request_firmware_into_buf.
In order to accept the enhanced API it has been requested that kernel
selftests and upstreamed driver utilize the API enhancement and so
are included in this patch series.
Also in this patch series is the addition of a new Broadcom VK driver
utilizing the new request_firmware_into_buf enhanced API.
Up to now, the firmware blob was read into memory allowing IMA to
verify the file signature. With this change, ima_post_read_file()
will not be able to verify the file signature.
(I don't think any of the other LSMs are on this hook, but you might
want to Cc the LSM or integrity mailing list.)
Scott, so it sounds we need a resolution for pread for IMA for file
signature verification. It seems that can be addressed though. Feel
free to submit the u32 flag changes which you picked up on though in
the meantime.
Sure, I can submit a new patch to change the existing enum to
a u32. For the new pread flags I am adding I could also leave as
a u32 or change from a u32 to an enum since there is currently only
one flag in use. Then, in the future if another flag was added we would
need
to change it back to a u32.
Please let me know what you prefer for the pread_flags.
Luis
Thanks,
Scott
