On Thu 14 May 07:12 PDT 2020, Linus Walleij wrote: > On Thu, May 14, 2020 at 8:04 AM Bjorn Andersson > <bjorn.andersson@xxxxxxxxxx> wrote: > > On Wed 29 Apr 14:34 PDT 2020, Rob Herring wrote: > > > On Thu, Apr 16, 2020 at 11:19:06PM -0700, Bjorn Andersson wrote: > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > > [..] > > > > +#PIN CONFIGURATION NODES > > > > +patternProperties: > > > > + '^.*$': > > > > + if: > > > > + type: object > > > > + then: > > > > > > Needs a $ref to the standard properties. > > > > > > Would be good to show a child node in the example too. (And try having > > > an error in a standard property type to verify you get an error). > > > > > > > Finally looked into this. > > Can you send an incremental patch because otherwise I have > to revert the patch that I merged (maybe to trigger happy, mea culpa). > I appreciate that you merged this already, so I'm happy to fix this incrementally. > (If it's too hard I can just revert it.) > Afaict there are two different $refs available with standard properties and adding either one works, but I don't understand how to add both. Also $ref'ing pincfg-node.yaml means that the binding suddenly accepts standard properties that the hardware doesn't support, so I would like to be able to reduce this list somehow... But I don't see anything preventing this from being done incrementally. Thanks, Bjorn
