On 13.5.2020 15.40, Greg Kroah-Hartman wrote: > On Wed, May 13, 2020 at 03:19:29PM +0300, Mathias Nyman wrote: >> On 6.5.2020 9.00, Vinod Koul wrote: >>> This series add support for Renesas USB controllers uPD720201 and uPD720202. >>> These require firmware to be loaded and in case devices have ROM those can >>> also be programmed if empty. If ROM is programmed, it runs from ROM as well. >>> >>> This includes patches from Christian which supported these controllers w/o >>> ROM and later my patches for ROM support and debugfs hook for rom erase and >>> export of xhci-pci functions. >>> >> >> First four patches look ok to me, but 5/5 that adds rom erase debugfs support >> still needs some work. >> >> If you prefer I can take the first four, maybe we can get them to 5.8, and then >> later add that debugs rom erase support. >> >> Let me know what you prefer > > Oops, I just added all of these to my testing tree :) > > What's wrong with the debugfs patch? I can drop it, but it seemed > simple enough to me. Added "usb_renesas" directory under debugfs root when we have easily accessible debugfs/usb/xhci directory to use as parent. Also not checking if adding directory failed (if debufs not supported) -Mathias
