AW: [PATCH -next] bus: mhi: core: Fix some error return code

[Walter Harms <wharms@xxxxxx>]

Hello guys,
some nitpicking ...
the prefered kernalstyle is:

if (condition)
   set error_code
   do something

from what i can see it is

 set error_code
      if (condition)

jm2c
 re,
 wh

________________________________________
Von: kernel-janitors-owner@xxxxxxxxxxxxxxx <kernel-janitors-owner@xxxxxxxxxxxxxxx> im Auftrag von Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Gesendet: Montag, 11. Mai 2020 12:31:24
An: Wei Yongjun
Cc: Hemant Kumar; Jeffrey Hugo; Greg Kroah-Hartman; Sujeev Dias; Siddartha Mohanadoss; linux-arm-msm@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; Hulk Robot
Betreff: Re: [PATCH -next] bus: mhi: core: Fix some error return code

On 0509, Wei Yongjun wrote:
> Fix to return negative error code from the error handling case
> instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe().
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/init.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index eb2ab058a01d..1f8c82603179 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl)
>       }
>
>       /* Setup cmd context */
> +     ret = -ENOMEM;
>       mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl,
>                                               sizeof(*mhi_ctxt->cmd_ctxt) *
>                                               NR_OF_CMD_RINGS,
> @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev)
>               }
>       }
>
> +     ret = -EINVAL;
>       if (dl_chan) {
>               /*
>                * If channel supports LPM notifications then status_cb should
>
>
>