On 27 April 2020 12:20:43 PM IST, Markus Elfring <Markus.Elfring@xxxxxx> wrote: >>> I propose again to add a jump target so that a bit of exception >handling code >>> can be better reused at the end of this function implementation. >>> >https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b2768df24ec400dd4f7fa79542f797e904812053#n450 >>> >> >> Matter of taste! goto's are really useful if there are multiple exit >paths >> available. But in this case there is only one and I don't think we >may add >> anymore in future. So I'll keep it as it is. > >Do you hope that an other optimiser software will avoid duplicate code >like kfree_skb(skb) calls from if branches? > Doh. I didn't notice the previous kfree in skb_linearize(). Will spin v3 incorporating this change. Thanks, Mani >Regards, >Markus -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
