On Thu 23 Apr 21:54 PDT 2020, Stephen Boyd wrote:
> Move the WARN_ON() into the if condition so the compiler can see that
> the branch is unlikely() and possibly optimize it better.
>
> Cc: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
> drivers/soc/qcom/rpmh-rsc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index 462dd267afef..f7763f008e03 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -373,10 +373,8 @@ static irqreturn_t tcs_tx_done(int irq, void *p)
>
> for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) {
> req = get_req_from_tcs(drv, i);
> - if (!req) {
> - WARN_ON(1);
> + if (WARN_ON(!req))
> goto skip;
> - }
>
> err = 0;
> for (j = 0; j < req->num_cmds; j++) {
> --
> Sent by a computer, using git, on the internet
>
