On Wed, Apr 15, 2020 at 02:23:29PM +0530, Sandeep Maheswaram (Temp) wrote: > Hi Rob, > > Any suggestions to solve this error in assigned-clock-rates > On 4/6/2020 10:09 PM, Sandeep Maheswaram (Temp) wrote: > > Hi Rob, > > > > On 4/4/2020 10:47 PM, Rob Herring wrote: > > > On Thu, Mar 26, 2020 at 12:36:07PM +0530, Sandeep Maheswaram wrote: > > > > Convert USB DWC3 bindings to DT schema format using json-schema. > > > > > > > > Signed-off-by: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx> > > > > --- > > > > .../devicetree/bindings/usb/qcom,dwc3.txt | 104 > > > > -------------- > > > > .../devicetree/bindings/usb/qcom,dwc3.yaml | 158 > > > > +++++++++++++++++++++ > > > > 2 files changed, 158 insertions(+), 104 deletions(-) > > > > delete mode 100644 > > > > Documentation/devicetree/bindings/usb/qcom,dwc3.txt > > > > create mode 100644 > > > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > > > b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > > > new file mode 100644 > > > > index 0000000..0f69475 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml ... > > > > + items: > > > > + - description: Must be 19.2MHz (19200000). > > > Sounds like a constraint: > > > > > > - const: 19200000 > > > > > > > + - description: Must be >= 60 MHz in HS mode, >= 125 MHz > > > > in SS mode. > > > - minimum: 60000000 > > > maximum: ? > > > > Tried as below but facing errors > > > > assigned-clock-rates: > > items: > > - const: 19200000 > > - minimum: 60000000 > > maximum: 150000000 > > > > Errors > > > > linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: > > usb@a6f8800: assigned-clock-rates: Additional items are not allowed > > ([150000000] was unexpected) > > linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: > > usb@a6f8800: assigned-clock-rates:0: [19200000] is too short > > linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: > > usb@a6f8800: assigned-clock-rates: [[19200000], [150000000]] is too long judging from the error messages my uneducated guess is that the above rules for assigned-clock-rates expect a single tuple of two elements, not two tuples with a single element, i.e. assigned-clock-rates = <19200000, 150000000>; instead of assigned-clock-rates = <19200000>, <150000000>; I experimented a bit but couldn't find the magic incantation to appease the schema deities. Rob, could you please help to distentangle this? Thanks Matthias
