On Tue, Apr 14, 2020 at 12:14 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > On Tue, Apr 14, 2020 at 11:57 AM John Stultz <john.stultz@xxxxxxxxxx> wrote: > > > > This patch fixes a regression in 5.7-rc1. > > > > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 > > PHY support"), the change was made to add "qcom,qusb2-v2-phy" > > as a generic compat string. However the change also removed > > the "qcom,sdm845-qusb2-phy" compat string, which is documented > > in the binding and already in use. > > > > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string > > which allows the driver to continue to work with existing dts > > entries such as found on the db845c. > > > > Cc: Andy Gross <agross@xxxxxxxxxx> > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: Doug Anderson <dianders@xxxxxxxxxxxx> > > Cc: Manu Gautam <mgautam@xxxxxxxxxxxxxx> > > Cc: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx> > > Cc: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > Cc: Kishon Vijay Abraham I <kishon@xxxxxx> > > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > > Cc: devicetree@xxxxxxxxxxxxxxx > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support") > > Reported-by: YongQin Liu <yongqin.liu@xxxxxxxxxx> > > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> > > Re-adding reviews from: > https://lore.kernel.org/r/158631458374.216820.17829557619378130779@xxxxxxxxxxxxxxxxxxxxxxxxxx > https://lore.kernel.org/r/CAD=FV=Wh9_4a-cDGPdpMrXUi_HmJvS-a2Ubeyo5WG3sgwVWKKQ@xxxxxxxxxxxxxx > > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Ah! Sorry, I thought I had added those to my git commit, but apparently I didn't! Many thanks! -john