On Mon 13 Apr 17:37 PDT 2020, Ansuel Smith wrote: > Fix a typo in the readl/writel accessor conversion where val is used > instead of pol changing the behavior of the original code. > > Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> Thank you Ansuel Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> Linus, when you apply this please add Cc: stable@xxxxxxxxxxxxxxx Thanks, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 1a948c3f54b7..9f1c9951949e 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl, > > pol = msm_readl_intr_cfg(pctrl, g); > pol ^= BIT(g->intr_polarity_bit); > - msm_writel_intr_cfg(val, pctrl, g); > + msm_writel_intr_cfg(pol, pctrl, g); > > val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit); > intstat = msm_readl_intr_status(pctrl, g); > -- > 2.25.1 >
