> in PCIe driver > > Hi Ansuel, > > On 4/8/20 3:36 PM, ansuelsmth@xxxxxxxxx wrote: > >> PCIe driver > >> > >> Ansuel, > >> > >> On 4/2/20 3:11 PM, Ansuel Smith wrote: > >>> Aux and Ref clk are missing in pcie qcom driver. > >>> Add support in the driver to fix pcie inizialization in ipq806x. > >>> > >>> Fixes: 82a82383 PCI: qcom: Add Qualcomm PCIe controller driver > >> > >> this should be: > >> > >> Fixes: 82a823833f4e PCI: qcom: Add Qualcomm PCIe controller driver > >> > >> and add: > >> > >> Cc: stable@xxxxxxxxxxxxxxx # v4.5+ > >> > >> But, I wonder, as apq8064 shares the same ops_2_1_0 how it worked > until > >> now. Something more I cannot find such clocks for apq8064, which > means > >> that this patch will break it. > >> > >> One option is to use those new clocks only for ipq806x. > >> > > > > How to add this new clocks only for ipq806x? Check the compatible and > add > > them accordingly? > > > > Yes, through of_device_is_compatible(). See how we done this in > qcom_pcie_get_resources_2_4_0. > > I thought about second option though - encoder what clocks we have for > any SoC but if you take into that direction you have to change the whole > driver :) > > Another option is to use clk_get_optional() for the clocks which you > have on ipq806x (and don't have on apq8064). Please research this one > first. > > -- > regards, > Stan Ok I will use get optional for the extra clocks. Should I add a warning if they are not present? Also what about the extra reset? Should I follow the same approach? Thx for the suggestions.
