Hi, On 4/3/2020 5:56 AM, Ansuel Smith wrote: > This has lost in the original push for the dwc3 qcom driver. > This is needed for ipq806x SoC as without this the usb ports > doesn't work at all. > > Signed-off-by: Andy Gross <agross@xxxxxxxxxxxxxx> > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > --- > drivers/phy/qualcomm/Kconfig | 12 + > drivers/phy/qualcomm/Makefile | 1 + > drivers/phy/qualcomm/phy-qcom-dwc3.c | 578 +++++++++++++++++++++++++++ > 3 files changed, 591 insertions(+) > create mode 100644 drivers/phy/qualcomm/phy-qcom-dwc3.c > > diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig > index e46824da29f6..3d45a9156f85 100644 > --- a/drivers/phy/qualcomm/Kconfig > +++ b/drivers/phy/qualcomm/Kconfig > @@ -91,3 +91,15 @@ config PHY_QCOM_USB_HSIC > select GENERIC_PHY > help > Support for the USB HSIC ULPI compliant PHY on QCOM chipsets. > + > +config PHY_QCOM_DWC3 Please rename to PHY_QCOM_IPQ806X_USB > + tristate "QCOM DWC3 USB PHY support" > + depends on ARCH_QCOM > + depends on HAS_IOMEM > + depends on OF > + select GENERIC_PHY > + help > + This option enables support for the Synopsis PHYs present inside the > + Qualcomm USB3.0 DWC3 controller. This driver supports both HS and SS > + PHY controllers. Please mention that driver supports only IPQ806x, as it can't be used for all QCOM phy and dwc3 controllers wrappers. > + > diff --git a/drivers/phy/qualcomm/Makefile b/drivers/phy/qualcomm/Makefile > index 283251d6a5d9..04c5a8da941a 100644 > --- a/drivers/phy/qualcomm/Makefile > +++ b/drivers/phy/qualcomm/Makefile > @@ -10,3 +10,4 @@ obj-$(CONFIG_PHY_QCOM_UFS_14NM) += phy-qcom-ufs-qmp-14nm.o > obj-$(CONFIG_PHY_QCOM_UFS_20NM) += phy-qcom-ufs-qmp-20nm.o > obj-$(CONFIG_PHY_QCOM_USB_HS) += phy-qcom-usb-hs.o > obj-$(CONFIG_PHY_QCOM_USB_HSIC) += phy-qcom-usb-hsic.o > +obj-$(CONFIG_PHY_QCOM_DWC3) += phy-qcom-dwc3.o > diff --git a/drivers/phy/qualcomm/phy-qcom-dwc3.c b/drivers/phy/qualcomm/phy-qcom-dwc3.c > new file mode 100644 > index 000000000000..f33da199ddde > --- /dev/null > +++ b/drivers/phy/qualcomm/phy-qcom-dwc3.c Rename to phy-qcom-ip806x-usb.c Please also add qcom_ipq806x_usb as prefix in the function names and structures etc. > @@ -0,0 +1,578 @@ > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project