On Thu, Apr 2, 2020 at 4:19 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > On Thu, Apr 2, 2020 at 4:08 PM John Stultz <john.stultz@xxxxxxxxxx> wrote: > > My understanding with dts bindings is that they are effectively an > > ABI. While maybe it makes sense to deprecate the > > "qcom,sdm845-qusb2-phy" string in the Documentation to avoid new > > users, I'd think we'd want to keep the support in the driver as we > > aren't supposed to have tight coupling between the DTB and kernel (at > > least for official bindings). > > If nothing else if we're going to land your patch, can you at least > put a comment in there that says "only needed to support legacy device > trees that didn't include "qcom,qusb2-v2-phy" in the compatible > string. Then the person who adds the next Qualcomm SoC will know not > to add themselves to the table too. Done. > > Granted, I've not gotten much experience with boards that were fully > > upstream and thus didn't have an eternally evolving dts file that had > > to be kept in sync with the kernel, so in practice either solution > > does work for me, but in theory it seems like we should at least > > pretend these things are stable. :) > > Yeah, I don't want to get into the whole stable ABI argument, but what > you say is the official word. The bindings are supposed to be a > stable ABI and it's a good goal to strive for. > > ...but in reality most people are OK with it not being quite so stable > as long as it's not hurting anyone. What should have happened here is > that the bindings and dts should have landed in one Linux version and > the driver change landed in the next Linux version. Now we're stuck > with the breakage, though. :( In general for "new" architectures > it's considered more OK to break compatibility, though I guess you can > argue whether sdm845 is really new enough. I guess to get at the meat > of the issue though: if you need a patch to fix your problem anyway, > why not land the patch that doesn't end up chewing extra up extra code > space and providing a bad example for someone to copy? > > Now certainly if changing your DTS was an undue burden (like you've > already baked device trees into firmware) there's no question we > should land your patch. I'm just not sure the lofty goal of "it's > supposed to be a stable ABI so let's add an entry to the table that > nobody will ever care about after the dts change lands" is enough of a > reason to land it now. Personally, I'm fine with either solution (as there's still dts changes for db845c pending that we're carrying), but I also want to make sure we're setting a good standard for future changes (as these sorts of things seem to bite me far too frequently on the db845c, sometimes even resulting in forced userland changes that we've so far been able to adapt to, but are not ideal). So I've resubmitted my version to let the maintainers decide. :) thanks -john
