On Mon, Mar 30, 2020 at 03:07:53PM +0200, Daniel Lezcano wrote: > > Hi Amit, > > On 30/03/2020 12:34, Amit Kucheria wrote: > > [ ... ] > > >>> I don't know why it's not consistent with the actual code in > >>> of-thermal.c, where there is even a comment stated: /* For now, > >>> thermal framework supports only 1 sensor per zone */ > >>> > >>> I think this is the place where developers should be informed > >>> about the limitation and not even try to put more sensors into > >>> the list. > >> > >> That is a good point. I'm currently "porting" the existing > >> binding as described in thermal.txt to yaml. If you look at some > >> of the example (c) in there, the bindings allow many sensors to a > >> zone mapping but the thermal core doesn't implement that > >> functionality. > >> > >> So should we fix the core code or change the bindings? Thoughts - > >> Rob, Daniel, Rui? > > > > Rob, Daniel: Any comments? We don't have any concerns for Linux > > backward compatibility since multiple sensors per zone isn't used > > anywhere. But asking since bindings are supposed to be > > OS-agnostic. > > IMO, we should remove it as it is not used anywhere. > > We still have to decide how we aggregate multiple sensors. The schema only needs to pass what currently exists (assuming no errors), so extending it later is fine with me. Rob
