Hi, On Thu, Mar 26, 2020 at 10:38 AM Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote: > > From: "Raju P.L.S.S.S.N" <rplsssn@xxxxxxxxxxxxxx> > > For RSCs that have sleep & wake TCS but no dedicated active TCS, wake > TCS can be re-purposed to send active requests. Once the active requests > are sent and response is received, the active mode configuration needs > to be cleared so that controller can use wake TCS for sending wake > requests. > > Introduce enable_tcs_irq() to enable completion IRQ for repurposed TCSes. > > Fixes: 2de4b8d33eab (drivers: qcom: rpmh-rsc: allow active requests from wake TCS) > Signed-off-by: Raju P.L.S.S.S.N <rplsssn@xxxxxxxxxxxxxx> > [mkshah: call enable_tcs_irq() within drv->lock, update commit message] > Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx> > --- > drivers/soc/qcom/rpmh-rsc.c | 77 +++++++++++++++++++++++++++++++-------------- > 1 file changed, 54 insertions(+), 23 deletions(-) I was writing my review of v1 at the same time you sent this. Looks like your patch does address the most important piece of feedback I had (adjusting the interrupt enable under spinlock), but some of the other feedback might be nice to incorporate: https://lore.kernel.org/r/CAD=FV=XmBQb8yfx14T-tMQ68F-h=3UHog744b3X3JZViu15+4g@xxxxxxxxxxxxxx -Doug
