Quoting Douglas Anderson (2020-03-13 13:46:52) > The geni serial driver's shutdown code had a special case to call > console_stop(). Grepping through the code, it was the only serial > driver doing something like this (the only other caller of > console_stop() was in serial_core.c). > > As far as I can tell there's no reason to call console_stop() in the > geni code. ...and a good reason _not_ to call it. Specifically if > you have an agetty running on the same serial port as the console then > killing the agetty kills your console and if you start the agetty > again the console doesn't come back. > > Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP") > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>