Hi, On Fri, Mar 6, 2020 at 4:00 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > @@ -889,12 +793,6 @@ static int rpmh_probe_tcs_config(struct platform_device *pdev, > */ > if (tcs->type == ACTIVE_TCS) > continue; > - > - tcs->cmd_cache = devm_kcalloc(&pdev->dev, > - tcs->num_tcs * ncpt, sizeof(u32), > - GFP_KERNEL); > - if (!tcs->cmd_cache) > - return -ENOMEM; During later code inspection I happened to notice that the "if" test above the code I removed can also be removed. I'll do that in v2. The code after the v1 patch doesn't hurt, it's just silly to have the "if (blah) continue" at the end of the loop. I'll wait on sending a v2 until I get some testing / review feedback on v1 or enough time passes. -Doug
