Re: [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/5/2020 11:12 AM, John Stultz wrote:
Allow the rpmpd driver to be loaded as a module.

The last time I tried this [1], I hit a limitation with pm_genpd_remove not cleaning up things right,
is that solved now?

[1] https://lkml.org/lkml/2019/1/17/1043


Cc: Todd Kjos <tkjos@xxxxxxxxxx>
Cc: Saravana Kannan <saravanak@xxxxxxxxxx>
Cc: Andy Gross <agross@xxxxxxxxxx>
Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Cc: linux-arm-msm@xxxxxxxxxxxxxxx
Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
---
  drivers/soc/qcom/Kconfig | 4 ++--
  drivers/soc/qcom/rpmpd.c | 5 ++++-
  2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index d0a73e76d563..af774555b9d2 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -123,8 +123,8 @@ config QCOM_RPMHPD
  	  for the voltage rail.
config QCOM_RPMPD
-	bool "Qualcomm RPM Power domain driver"
-	depends on QCOM_SMD_RPM=y
+	tristate "Qualcomm RPM Power domain driver"
+	depends on QCOM_SMD_RPM
  	help
  	  QCOM RPM Power domain driver to support power-domains with
  	  performance states. The driver communicates a performance state
diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
index 2b1834c5609a..9c0834913f3f 100644
--- a/drivers/soc/qcom/rpmpd.c
+++ b/drivers/soc/qcom/rpmpd.c
@@ -5,6 +5,7 @@
  #include <linux/init.h>
  #include <linux/kernel.h>
  #include <linux/mutex.h>
+#include <linux/module.h>
  #include <linux/pm_domain.h>
  #include <linux/of.h>
  #include <linux/of_device.h>
@@ -226,6 +227,7 @@ static const struct of_device_id rpmpd_match_table[] = {
  	{ .compatible = "qcom,qcs404-rpmpd", .data = &qcs404_desc },
  	{ }
  };
+MODULE_DEVICE_TABLE(of, rpmpd_match_table);
static int rpmpd_send_enable(struct rpmpd *pd, bool enable)
  {
@@ -421,4 +423,5 @@ static int __init rpmpd_init(void)
  {
  	return platform_driver_register(&rpmpd_driver);
  }
-core_initcall(rpmpd_init);
+module_init(rpmpd_init);
+MODULE_LICENSE("GPL");


--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux