On Wed 19 Feb 16:20 PST 2020, Stephen Boyd wrote: > The DT or ACPI tables should tell the driver what the irq flags are. > Given that this driver probes only on DT based platforms and those DT > platforms specify the irq flags we can safely drop the forced irq flag > setting here. > > Cc: Andy Gross <agross@xxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> Regards, Bjorn > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > drivers/watchdog/qcom-wdt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index eb47fe5ed280..c70e89013101 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -248,8 +248,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) > /* check if there is pretimeout support */ > irq = platform_get_irq_optional(pdev, 0); > if (irq > 0) { > - ret = devm_request_irq(dev, irq, qcom_wdt_isr, > - IRQF_TRIGGER_RISING, > + ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0, > "wdt_bark", &wdt->wdd); > if (ret) > return ret; > -- > Sent by a computer, using git, on the internet >