On 2020-02-11 23:54, Rob Herring wrote:
On Fri, Feb 7, 2020 at 12:10 AM Sai Prakash Ranjan
<saiprakash.ranjan@xxxxxxxxxxxxxx> wrote:
Hi Rob,
On 2020-02-07 00:08, Rob Herring wrote:
> On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote:
>> Add missing compatible for watchdog timer on QCS404,
>> SC7180, SDM845 and SM8150 SoCs.
>
> That's not what the commit does. You are changing what's valid.
>
> One string was valid, now 2 are required.
>
Does this look good?
No. First of all, what's the base for the diff? It's not what you
originally had nor incremental on top of this patch.
It was an incremental on top of this patch.
Second, a value of 'qcom,kpss-timer' or 'qcom,kpss-wdt' or
'qcom,scss-timer' will fail validation because 2 clauses of 'oneOf'
will be true.
I will just remove oneOf and add the missing compatibles to the enum.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
