On Wed, Feb 12, 2020 at 12:11:30AM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Thu, Feb 06, 2020 at 05:57:55PM +0100, Greg KH wrote: > > On Fri, Jan 31, 2020 at 07:19:55PM +0530, Manivannan Sadhasivam wrote: > > > --- /dev/null > > > +++ b/drivers/bus/mhi/core/init.c > > > @@ -0,0 +1,407 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. > > > + * > > > + */ > > > + > > > +#define dev_fmt(fmt) "MHI: " fmt > > > > This should not be needed, right? The bus/device name should give you > > all you need here from what I can tell. So why is this needed? > > > > The log will have only the device name as like PCI-E. But that won't specify > where the error is coming from. Having "MHI" prefix helps the users to > quickly identify that the error is coming from MHI stack. If the driver binds properly to the device, the name of the driver will be there in the message, so I suggest using that please. No need for this prefix... thanks, greg k-h
