Hi, On Sun, Feb 9, 2020 at 11:41 PM Sharat Masetty <smasetty@xxxxxxxxxxxxxx> wrote: > > This patch adds the required dt nodes and properties > to enabled A618 GPU. > > Signed-off-by: Sharat Masetty <smasetty@xxxxxxxxxxxxxx> In v4 I added my tags [1]. Please keep them for future patches unless something major changes. AKA: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 102 +++++++++++++++++++++++++++++++++++ > 1 file changed, 102 insertions(+) Just to summarize where we are: * As per my notes in v3 and v4 [1], this can't land until "mem_iface_clk" is in the bindings. Please post a patch for this and reply with a link here so others can follow the disucssion. * This also can't land until the gpucc bindings change from Taniya recently [2] lands. ...so we're in limbo waiting for the bindings to be resolved, but otherwise this patch looks good. [1] https://lore.kernel.org/r/CAD=FV=UEQ0mOXuDrSZrcJ8g6jb0eLf1Ttn+Mn7T6d2TpCMUcuA@xxxxxxxxxxxxxx [2] https://lore.kernel.org/r/1581307266-26989-1-git-send-email-tdas@xxxxxxxxxxxxxx -Doug