On 2020-02-10 08:31, Mark Brown wrote:
On Sun, Feb 09, 2020 at 10:47:42AM -0500, Adam Serbinski wrote:
+#define AFE_API_VERSION_PCM_CONFIG 0x1
+/* Enumeration for the auxiliary PCM synchronization signal
+ * provided by an external source.
+ */
+
+#define AFE_PORT_PCM_SYNC_SRC_EXTERNAL 0x0
+/* Enumeration for the auxiliary PCM synchronization signal
+ * provided by an internal source.
+ */
This is a *weird* commenting style for these #defines and it's not
consistent within the block, I'm seeing at least 3 different styles.
I will clean up the commenting.
+ default:
+ break;
+ }
Why is this not returning an error on unsupported values?
Only to be consistent with the pre-existing implementation for i2s
ports.
I will add an error return.
+
+ switch (cfg->sample_rate) {
+ case 8000:
+ pcfg->pcm_cfg.frame_setting = AFE_PORT_PCM_BITS_PER_FRAME_128;
+ break;
+ case 16000:
+ pcfg->pcm_cfg.frame_setting = AFE_PORT_PCM_BITS_PER_FRAME_64;
+ break;
+ }
Same here.
I will also add the error return here.
