Hi, On Thu, Jan 30, 2020 at 10:04 AM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > Misc cleanups as part of this patch: > > - sm8150 was claimed to be same set of clocks as sc7180, but driver > > and dts appear to say that "bi_tcxo_ao" doesn't exist. Fixed. > > Someone will probably want to change this at some point. I have no insight into sm8150, but I guess I assumed that since it wasn't in the driver that maybe sm8150 just doesnt have this hookup? I'm happy to add it back in. > > +description: > > + Qualcomm global clock control module which supports the clocks, resets and > > + power domains on APQ8064. > > It would be great if this could also point to the > include/dt-bindings/clock/qcom,apq8064.h file here. If you don't resend > this patch then I will try to remember to make this addition to the > binding docs. You're saying that the top-level description for all these should point to the header file? Seems line a sane idea. I guess we'd need to do that for all of them? I could spin with that if you want, but we could also do a follow-up patch? -Doug
