On Tue, Jan 28, 2020 at 08:24:53AM +0100, Greg KH wrote: > On Tue, Jan 28, 2020 at 12:07:57PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Jan 27, 2020 at 07:52:13AM -0700, Jeffrey Hugo wrote: > > > > > MHI_EE_PBL does not appear to be defined. Are you perhaps missing an > > > > > include? > > > > > > > > > > > > > It is defined in mhi.h as mhi_ee_type. > > > > > > mhi.h isn't included here. You are relying on the users of this file to > > > have included that, in particular to have included it before this file. That > > > tends to result in really weird errors later on. It would be best to > > > include mhi.h here if you need these definitions. > > > > > > Although, I suspect this struct should be moved out of internal.h and into > > > mhi.h since clients need to know this, so perhaps this issue is moot. > > > > > > > Yep. I've moved this enum to mhi.h since it will be used by controller drivers. > > You can find this change in next iteration. > > Both of you please learn to properly trim emails, digging through 1200 > lines to try to find 2 new lines in the middle is unworkable. > Oops. Sorry! Will do it for future replies. Thanks, Mani > greg k-h
