On Wed 22 Jan 22:46 PST 2020, Stephen Boyd wrote: > Quoting Venkata Narendra Kumar Gutta (2020-01-16 15:39:49) > > @@ -490,6 +512,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) > > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > > { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, > > { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, > > + { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, > > We should sort this on compatible. > Yes we should, in case this was a request I sent out a patch for this: https://lore.kernel.org/linux-arm-msm/20200124175934.3937473-1-bjorn.andersson@xxxxxxxxxx/ Regards, Bjorn > > { } > > }; > > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);