On Fri 24 Jan 04:06 PST 2020, Harigovindan P wrote:
> Add display, DSI hardware DT nodes for sc7180.
>
> Signed-off-by: Harigovindan P <harigovi@xxxxxxxxxxxxxx>
Thanks for respinning this Harigovindan, just a few more small things
below.
Are the drivers ready for me to merge this?
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
[..]
> +&pm6150l_gpio {
> + disp_pins {
You can omit this subnode level, i.e. just put disp_pins_default
directly in &pm6150l_gpio.
> + disp_pins_default: disp_pins_default{
> + pins = "gpio3";
> + function = "func1";
> + qcom,drive-strength = <2>;
> + power-source = <0>;
> + bias-disable;
> + output-low;
> + };
> + };
> +};
> +
> &qspi_clk {
> pinconf {
> pins = "gpio63";
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 3bc3f64..3ebc45b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1184,6 +1184,130 @@
> #power-domain-cells = <1>;
> };
>
> + mdss: display_subsystem@ae00000 {
Whenever possible, use - and not _ in node names.
Regards,
Bjorn
